[prometheus-adapter] Use full duration format for default certificate values #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cert-Manager converts simple duration values to their full format: `1h` ends up as `1h0m0s` GitOps tools like Argo CD keep seeing this as a change and never reach a 'synced' state because they see this as a diff: `1h0m0s != 1h`. Using the full format fixes that. Signed-off-by: Maikel <maikelvl@users.noreply.github.com>
maikelvl
requested review from
hectorj2f,
MattiasGees and
steven-sheehy
as code owners
Matiasmct
pushed a commit
to giffgaff/prometheus-charts
that referenced
this pull request
Mar 20, 2024
…ommunity#3878) Cert-Manager converts simple duration values to their full format: `1h` ends up as `1h0m0s` GitOps tools like Argo CD keep seeing this as a change and never reach a 'synced' state because they see this as a diff: `1h0m0s != 1h`. Using the full format fixes that. Signed-off-by: Maikel <maikelvl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Cert-Manager converts simple duration values to their full format:
1hends up as1h0m0sGitOps tools like Argo CD keep seeing this as a change and never reach a 'synced' state because they see this as a diff:
1h0m0s != 1h. Using the full format fixes that.Checklist
[prometheus-couchdb-exporter])