[kube-prometheus-stack] Allow to directly config prometheus.spec and alertmanager.spec #3920
Conversation
… alertmanager.spec Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
jkroepke
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
|
@jkroepke WDYT of adding a couple of values from these new keys to https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/ci/03-non-defaults-values.yaml? This way we can ensure they keep working as expected. |
|
@GMartinez-Sisti tests added |
|
Did you mean |
jkroepke
changed the title
Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
GoLand spell correction, yeah. Thanks! |
I really like this way to testing and we should think about the make it as requirement ... |
I agree we should use it more, the only downside is that it can get hard to troubleshoot when something fails or increase the duration of the tests if there are a lot of test files. Another approach that I like a lot is helm-unittest, but they only test the template output and don't check server side if it's actually a valid config. It would be a nice complement to chart-tester (ct). |
Internally, we run helm install command with --debug which solves the throubleshoot issues |
…166) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kube-prometheus-stack](https://github.com/prometheus-operator/kube-prometheus) ([source](https://github.com/prometheus-community/helm-charts)) | minor | `51.9.4` -> `51.10.0` | --- ### Release Notes <details> <summary>prometheus-community/helm-charts (kube-prometheus-stack)</summary> ### [`v51.10.0`](https://github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.10.0) [Compare Source](prometheus-community/helm-charts@kube-prometheus-stack-51.9.4...kube-prometheus-stack-51.10.0) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Allow to directly config prometheus.spec and alertmanager.spec by [@​jkroepke](https://github.com/jkroepke) in prometheus-community/helm-charts#3920 **Full Changelog**: prometheus-community/helm-charts@prometheus-nginx-exporter-0.2.0...kube-prometheus-stack-51.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzcuMjguMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/166 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
…alertmanager.spec (prometheus-community#3920) * [kube-prometheus-stack] Allow to directory config prometheus.spec and alertmanager.spec Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * Add tests Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * Update charts/kube-prometheus-stack/values.yaml Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Sacha <sacha.smart@gmail.com>
…alertmanager.spec (prometheus-community#3920) * [kube-prometheus-stack] Allow to directory config prometheus.spec and alertmanager.spec Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * Add tests Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> * Update charts/kube-prometheus-stack/values.yaml Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
… alertmanager.spec
What this PR does / why we need it
This is useful, if complex templating is required or properties are not exposed by the chart yet.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])