[prometheus-pgbouncer-exporter] pin image + use appVersion correctly #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
DrFaust92
force-pushed
the
pgbouncer-exporter-pin-image
branch
from
f8029fa
to
b788ac1
Compare
DrFaust92
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
zeritti
requested changes
Mar 23, 2024
There was a problem hiding this comment.
Thank you, @DrFaust92, for your PR. As the major number is being raised, we have to provide an upgrade note. On the other hand, a development release may include breaking changes. I'd prefer keeping the release still at major 0.
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
|
zeritti reverted the major bump and now its a minor bump |
zeritti
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])