Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-mysql-exporter] Manual credentials specification for mult… #4485

Merged
merged 2 commits into from Apr 25, 2024

Conversation

bylit
Copy link
Contributor

@bylit bylit commented Apr 24, 2024

…uple targets

What this PR does / why we need it

PR allows manually specify credentials for multi-target scraping.
Currently only usage of existing secrets is possible.

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

…uple targets

Signed-off-by: alit-by <litasov.o@gmail.com>
monotek
monotek previously approved these changes Apr 25, 2024
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix linting error

Signed-off-by: alit-by <litasov.o@gmail.com>
@bylit
Copy link
Contributor Author

bylit commented Apr 25, 2024

Done, please verify.

@monotek monotek merged commit ee961be into prometheus-community:main Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants