[prometheus-node-exporter] Add externalTrafficPolicy to prometheus node exporter service spec #4512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junchil
force-pushed
the
main
branch
4 times, most recently
from
47e131b
to
31bb76a
Compare
zeritti
requested changes
May 4, 2024
|
Hi @zeritti thank you for your review. pls review it again, thanks! |
Signed-off-by: Steve Liu <ljc1993917@gmail.com>
Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Steve Liu <ljc1993917@gmail.com>
Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Steve Liu <ljc1993917@gmail.com>
Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Steve Liu <ljc1993917@gmail.com>
zeritti
approved these changes
May 5, 2024
|
Hi @zeritti how can I merge this pr? |
kireque
pushed a commit
to kireque/home-ops
that referenced
this pull request
May 6, 2024
…#527) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [prometheus-node-exporter](https://togithub.com/prometheus/node_exporter/) ([source](https://togithub.com/prometheus-community/helm-charts)) | minor | `4.33.0` -> `4.34.0` | --- ### Release Notes <details> <summary>prometheus-community/helm-charts (prometheus-node-exporter)</summary> ### [`v4.34.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/prometheus-node-exporter-4.34.0) [Compare Source](https://togithub.com/prometheus-community/helm-charts/compare/prometheus-node-exporter-4.33.0...prometheus-node-exporter-4.34.0) A Helm chart for prometheus node-exporter #### What's Changed - \[prometheus-node-exporter] Add externalTrafficPolicy to prometheus node exporter service spec by [@​junchil](https://togithub.com/junchil) in [prometheus-community/helm-charts#4512 #### New Contributors - [@​junchil](https://togithub.com/junchil) made their first contribution in [prometheus-community/helm-charts#4512 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-58.4.0...prometheus-node-exporter-4.34.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDIuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM0Mi4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
wilfriedroset
pushed a commit
to wilfriedroset/helm-charts
that referenced
this pull request
May 8, 2024
…de exporter service spec (prometheus-community#4512) * add externalTrafficPolicy to prometheus node exporter service spec Signed-off-by: Steve Liu <ljc1993917@gmail.com> * Update charts/prometheus-node-exporter/templates/service.yaml Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Steve Liu <ljc1993917@gmail.com> * Update charts/prometheus-node-exporter/values.yaml Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Steve Liu <ljc1993917@gmail.com> * Update charts/prometheus-node-exporter/Chart.yaml Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com> Signed-off-by: Steve Liu <ljc1993917@gmail.com> --------- Signed-off-by: Steve Liu <ljc1993917@gmail.com> Co-authored-by: zeritti <47476160+zeritti@users.noreply.github.com>
lambchop4prez
added a commit
to lambchop4prez/network
that referenced
this pull request
May 26, 2024
…116) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [prometheus-node-exporter](https://togithub.com/prometheus/node_exporter/) ([source](https://togithub.com/prometheus-community/helm-charts)) | minor | `4.33.0` -> `4.34.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus-community/helm-charts (prometheus-node-exporter)</summary> ### [`v4.34.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/prometheus-node-exporter-4.34.0) [Compare Source](https://togithub.com/prometheus-community/helm-charts/compare/prometheus-node-exporter-4.33.0...prometheus-node-exporter-4.34.0) A Helm chart for prometheus node-exporter #### What's Changed - \[prometheus-node-exporter] Add externalTrafficPolicy to prometheus node exporter service spec by [@​junchil](https://togithub.com/junchil) in [prometheus-community/helm-charts#4512 #### New Contributors - [@​junchil](https://togithub.com/junchil) made their first contribution in [prometheus-community/helm-charts#4512 **Full Changelog**: prometheus-community/helm-charts@kube-prometheus-stack-58.4.0...prometheus-node-exporter-4.34.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/lambchop4prez/network). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add externalTrafficPolicy config option to node exporter service.
When the service type set to nodeport, we can have this externalTrafficPolicy config set to local so service only forward request to the local node exporter pod.
@gianrubio @zanhsieh @zeritti
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])