[prometheus-pushgateway] Align resource label handling

[skhalash]

Signed-off-by: Stanislav Khalash stanislav.khalash@sap.com

What this PR does / why we need it:

Most of the templated resources are using the prometheus-pushgateway.defaultLabels template to insert labels. The only difference is Ingress and ServiceMonitor, where the labels are hard-coded. This PR eliminates code duplication by aligning label handling for all resources.

Checklist

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[skhalash]

Hi @gianrubio! Could you please review this one?

[monotek]

@scottrigby
could you jump in with a review / merge please?

[scottrigby]

Ah, @cstaud is also a maintainer of this chart but is not invited to the @prometheus-community/helm-charts-maintainers team 😮 I see this was worked around here #195 (comment).

@prometheus-community/helm-charts-admins (@SuperQ or @bismarck @brancz) would you please invite him to the helm-charts-maintainers team? Thanks 😄

Let's wait just a bit to get that sorted or at least give @cstaud a chance to review. I was not aware this never happened, so he was never notified of this PR and hasn't had a chance to review yet.

[bismarck]

@scottrigby I don't believe I have permission to add @cstaud to the team?

[scottrigby]

@bismarck apologies, autocomplete snafu 🤦‍♂️ I meant @brancz 😄

I have also opened this issue prometheus-community/community#31

[skhalash]

@scottrigby @brancz Hey folks, sorry for bugging you, but did you have a chance to review the PR?

[SuperQ]

@scottrigby Sorry, I didn't see the add member issue. Invite sent.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[zanhsieh]

@scottrigby
could you jump in with a review / merge please?

[scottrigby]

Hi yes, I believe we've waited long enough per our PROCESSES doc 👌

[scottrigby]

Can not merge on my phone now - as settings need to be temporarily changed to do so in the GitHub app - can do on laptop tomorrow.

[skhalash]

Hey @scottrigby, just a friendly reminder ;) Could you please merge it?

[scottrigby]

Done! ✅