Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-state-metrics] separate ServiceMonitor values so they can be independently configured #4562

Merged
merged 2 commits into from
May 31, 2024

Conversation

kbweave
Copy link
Contributor

@kbweave kbweave commented May 24, 2024

What this PR does / why we need it

This PR allows the two ServiceMonitor endpoints http and metrics to be separately configured. Relabelings that need to be done on one endpoint likely don't need to happen on the other.
The change is structured so it will be backwards compatible with existing values.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

…dependently configured

Signed-off-by: Kyle Brown <kyle.brown@getweave.com>
@dotdc dotdc merged commit 3780d77 into prometheus-community:main May 31, 2024
4 checks passed
@dotdc
Copy link
Member

dotdc commented May 31, 2024

Thank you for your contribution @kbweave !

kireque pushed a commit to kireque/home-ops that referenced this pull request Jun 1, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[kube-state-metrics](https://togithub.com/kubernetes/kube-state-metrics/)
([source](https://togithub.com/prometheus-community/helm-charts)) |
patch | `5.19.0` -> `5.19.1` |

---

### Release Notes

<details>
<summary>prometheus-community/helm-charts (kube-state-metrics)</summary>

###
[`v5.19.1`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-state-metrics-5.19.1)

[Compare
Source](https://togithub.com/prometheus-community/helm-charts/compare/kube-state-metrics-5.19.0...kube-state-metrics-5.19.1)

Install kube-state-metrics to generate and expose cluster-level metrics

#### What's Changed

- \[kube-state-metrics] separate ServiceMonitor values so they can be
independently configured by
[@&#8203;kbweave](https://togithub.com/kbweave) in
[prometheus-community/helm-charts#4562

#### New Contributors

- [@&#8203;kbweave](https://togithub.com/kbweave) made their first
contribution in
[prometheus-community/helm-charts#4562

**Full Changelog**:
prometheus-community/helm-charts@prometheus-smartctl-exporter-0.9.0...kube-state-metrics-5.19.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODIuNCIsInVwZGF0ZWRJblZlciI6IjM3LjM4Mi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
lukas-unity pushed a commit to lukas-unity/helm-charts-1 that referenced this pull request Jun 6, 2024
…dependently configured (prometheus-community#4562)

Signed-off-by: Kyle Brown <kyle.brown@getweave.com>
Signed-off-by: Lukas Monkevicius <lukas.monkevicius@unity3d.com>
Maven35 pushed a commit to Maven35/helm-charts that referenced this pull request Jun 6, 2024
…dependently configured (prometheus-community#4562)

Signed-off-by: Kyle Brown <kyle.brown@getweave.com>
Maven35 pushed a commit to Maven35/helm-charts that referenced this pull request Jun 6, 2024
…dependently configured (prometheus-community#4562)

Signed-off-by: Kyle Brown <kyle.brown@getweave.com>
Signed-off-by: Maven35 <Charles.Tony.Gibbs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants