-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-prometheus-stack] introduce PVC claim retention field in prometheus operator #4570
Merged
jkroepke
merged 9 commits into
prometheus-community:main
from
Woojciech:kube-prometheus-stack-pvc-claim-retention
May 31, 2024
Merged
[kube-prometheus-stack] introduce PVC claim retention field in prometheus operator #4570
jkroepke
merged 9 commits into
prometheus-community:main
from
Woojciech:kube-prometheus-stack-pvc-claim-retention
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erator Signed-off-by: Wojciech Suszko <wsuszko14@gmail.com>
Signed-off-by: Wojciech Suszko <wsuszko14@gmail.com>
Woojciech
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
May 27, 2024 21:03
Signed-off-by: Wojciech Suszko <wsuszko14@gmail.com>
jkroepke
reviewed
May 27, 2024
charts/kube-prometheus-stack/templates/prometheus/prometheus.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Wojciech Suszko <wsuszko14@gmail.com>
Signed-off-by: Wojciech Suszko <53919286+Woojciech@users.noreply.github.com>
Signed-off-by: Wojciech Suszko <wsuszko14@gmail.com>
jkroepke
previously approved these changes
May 28, 2024
Signed-off-by: Wojciech Suszko <wsuszko14@gmail.com>
fixed trailing spaces, hopefully everything will be well formatted this time :) |
Signed-off-by: Wojciech Suszko <wsuszko14@gmail.com>
Hi @jkroepke can I please ask you for re-approval, as I fixed all the required checks? |
jkroepke
approved these changes
May 31, 2024
lukas-unity
pushed a commit
to lukas-unity/helm-charts-1
that referenced
this pull request
Jun 6, 2024
…heus operator (prometheus-community#4570) Signed-off-by: Lukas Monkevicius <lukas.monkevicius@unity3d.com>
Maven35
pushed a commit
to Maven35/helm-charts
that referenced
this pull request
Jun 6, 2024
Maven35
pushed a commit
to Maven35/helm-charts
that referenced
this pull request
Jun 6, 2024
…heus operator (prometheus-community#4570) Signed-off-by: Maven35 <Charles.Tony.Gibbs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR exposes persistentVolumeClaimRetentionPolicy field of Prometheus / PrometheusAgent, a CRD resource from Prometheus operator. PersistentVolumeClaimRetentionPolicy is a feature introduced for StatefulSets (by default in K8s 1.27.0+), this feature lets us decide whether the StatefulSet should delete or retain it's corresponding PVC's it is deleted or scaled. It is particularly useful in environments where stale volumes can grow in amount, causing additional costs or clutter in general. The CRD field itself was added to Prometheus operator around October last year, however not yet exposed in kube-prometheus-stack.
Change provided in this PR is based on the work already present in the prometheus chart , please see the special notes section.
Special notes for your reviewer
This PR is based on the previous work which was made in the prometheus chart, as per links provided below. I wanted to add this exact feature into the chart and I found that it was already done in the linked prometheus operator chart.
Please let me know if relying on the previous implementation has any legal implications (licensing etc.) - if I should for example add authors of mentioned changes as co-authors or provide credits for their work in any other way.
helm-charts/charts/prometheus/templates/sts.yaml
Line 17 in c43f4b2
helm-charts/charts/prometheus/values.yaml
Line 588 in c43f4b2
Checklist
[prometheus-couchdb-exporter]
)