[prometheus-node-exporter] permit to customize service clusterIP #4597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for comments, i'll sign the DCO after that, if you agree with the change |
nerzhul
force-pushed
the
patch-node-exporter
branch
from
620bb90
to
9069ada
Compare
nerzhul
requested review from
xiu,
andrewgkew,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
nerzhul
force-pushed
the
patch-node-exporter
branch
from
9069ada
to
54f04d0
Compare
|
rebased, squashed & signed |
It permits to disable clusterIP which is not required to fetch metrics. On clusters with very huge node number always moving, it create a loadbalancer on each node using much memory and CPU due to watches from the service proxy Signed-off-by: Loic Blot <loic.blot@unix-experience.fr>
nerzhul
force-pushed
the
patch-node-exporter
branch
from
54f04d0
to
a9e1636
Compare
|
@zeritti thanks for your comments, all is fixed :) |
Signed-off-by: MH <zanhsieh@gmail.com>
zanhsieh
previously approved these changes
Jun 9, 2024
Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
zeritti
force-pushed
the
patch-node-exporter
branch
from
d9f7afe
to
c6342de
Compare
zeritti
approved these changes
Jun 9, 2024
kireque
pushed a commit
to kireque/home-ops
that referenced
this pull request
Jun 10, 2024
…#643) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [prometheus-node-exporter](https://togithub.com/prometheus/node_exporter/) ([source](https://togithub.com/prometheus-community/helm-charts)) | minor | `4.35.0` -> `4.36.0` | --- ### Release Notes <details> <summary>prometheus-community/helm-charts (prometheus-node-exporter)</summary> ### [`v4.36.0`](https://togithub.com/prometheus-community/helm-charts/releases/tag/prometheus-node-exporter-4.36.0) [Compare Source](https://togithub.com/prometheus-community/helm-charts/compare/prometheus-node-exporter-4.35.0...prometheus-node-exporter-4.36.0) A Helm chart for prometheus node-exporter #### What's Changed - \[prometheus-node-exporter] permit to customize service clusterIP by [@​nerzhul](https://togithub.com/nerzhul) in [prometheus-community/helm-charts#4597 #### New Contributors - [@​nerzhul](https://togithub.com/nerzhul) made their first contribution in [prometheus-community/helm-charts#4597 **Full Changelog**: prometheus-community/helm-charts@prometheus-node-exporter-4.35.0...prometheus-node-exporter-4.36.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTkuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM5OS44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It permits to disable clusterIP which is not required to fetch metrics. On cluster with very huge node number always moving, it create a loadbalancer on each node using much memory and CPU due to watches from the service proxy
What this PR does / why we need it
Permit to customize node-exporter ClusterIP field, permitting people to disable this ClusterIP which is always updating its backend when nodes are added created, generating much work on each {service,kube}-proxy pod on the cluster
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])