[kube-prometheus-stack] Add support for --enable-feature of alertmanager

[Sheikh-Abubaker]

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes [kube-prometheus-stack] Add support for --enable-feature for alertmanager #4543

Special notes for your reviewer

Checklist

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

[jkroepke]

this should work, too?

Suggested change

	{{- if .Values.alertmanager.enableFeatures }}
	enableFeatures:
	{{- range .Values.alertmanager.enableFeatures }}
	- {{ . | quote }}
	{{- end }}
	{{- end }}
	{{- with .Values.alertmanager.enableFeatures }}
	enableFeatures:
	{{- toYaml . | nindent 4 }}
	{{- end }}

[Sheikh-Abubaker]

sure it would, but if the features are listed without quotes, that is why I made use of quotes, but no worries if you want I can change it and in case of {{- with }} it completely slipped off my mind.

[jkroepke]

Could you explain, what you mean with the quotes? Do I miss something?

[Sheikh-Abubaker]

I meant if there is something like this in values.yaml

alertmanager:
  enableFeatures:
    - feature1
    - "feature2"

using quote would ensure the template renders it correctly as string, like this:

enableFeatures:
  - "feature1"
  - "feature2"

[jkroepke]

Ah, I see. Quotes are most of the time optional. They are only required, if strings are expected, but numbers are given.

with toYaml,

alertmanager:
  enableFeatures:
    - feature1
    - "feature2"

would result into:

alertmanager:
  enableFeatures:
    - feature1
    - feature2

[Sheikh-Abubaker]

yes that's right it just slipped off my mind to add with toYaml, apart from this I have updated the code, checkout the latest commit.