[kube-prometheus-stack] Allow autoTagVersion for hyperkube image #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentin Zayash <valioozz@gmail.com>
VLZZZ
requested review from
bismarck,
gianrubio,
gkarthiks,
scottrigby,
vsliouniaev and
Xtigyro
as code owners
|
@VLZZZ Thanks for you PR, please add your signoff to get DCO check passed. Click on the |
|
@VLZZZ not sure whether you want to do this, as I vaguely remember that the build of hyperkube is no longer supported in k/k |
|
@gkarthiks Thank you for providing all of the details! |
nf-npieros
pushed a commit
to nf-npieros/helm-charts
that referenced
this pull request
Jan 17, 2022
nf-npieros
pushed a commit
to nf-npieros/helm-charts
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valentin Zayash valioozz@gmail.com
What this PR does / why we need it:
This PR will allow to conditionally set image tag for
hyperkubedepending on installed Kubernetes version using Helm's built-inCapabilities.https://v2.helm.sh/docs/chart_template_guide/#built-in-objects
It will be really useful to avoid manual reconfiguration across clusters with different versions.
It won't affect existing installation until
autoTagVersionwill be set totrueSpecial notes for your reviewer:
This PR was previously opened to the
stable/chart- #23590Checklist
[prometheus-couchdb-exporter])