New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-state-metrics] Add: Kubernetes recommanded labels and custom labels #927
[kube-state-metrics] Add: Kubernetes recommanded labels and custom labels #927
Conversation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase / update version.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
So... are we ready to go? 🚀 👍🏻 |
For me this issue seems to very serious because it prevents from effective monitoring and alerting k8s resources based on their labels. I wonder why this doesn't have so much attention if the solution was done in May 2021, but still not being merged and released. Maybe community is not using this helm chart? |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
MERGED!!! 🥳 🎆 |
…bels (prometheus-community#927) * Add: Kubernetes recommanded labels Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: do not indent custom labels Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: template Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: clean code Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: clean code Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: clean code Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: clean code Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: clean code Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: role templating Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: typo Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Update: bump Chart version Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Update: Helm 3.6 recommendation Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Add: documentation Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: typo Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Fix: typo Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Update: bump chart version Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Update: major version Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Update: major version Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: GitHub <noreply@github.com>
Next of : kubernetes/kube-state-metrics#1387
Add Kubernetes recommanded labels https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter]
)