Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env var substitution #125

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Env var substitution #125

merged 1 commit into from
Aug 23, 2022

Conversation

rati3l
Copy link
Contributor

@rati3l rati3l commented Aug 20, 2022

Enable environmental variable substitution for jiralert config file.

@rati3l rati3l mentioned this pull request Aug 20, 2022
Open
bwplotka
bwplotka approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One comment only, otherwise LGTM (:

pkg/config/config.go Outdated Show resolved Hide resolved
@rati3l
missing DCO verification
9184260 
Signed-off-by: r3t4 <34656130+r3t4@users.noreply.github.com>
@splitt3r
Copy link

Great work 🚀

bwplotka
bwplotka approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Thanks!

@bwplotka bwplotka merged commit 43a23d5 into prometheus-community:master Aug 23, 2022
@splitt3r splitt3r mentioned this pull request Aug 28, 2022
Open
@HelenaSeidel HelenaSeidel mentioned this pull request Sep 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splitt3r splitt3r splitt3r left review comments

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rati3l @splitt3r @bwplotka