Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit metric type switching #152

Merged
merged 1 commit into from
May 23, 2022
Merged

Use explicit metric type switching #152

merged 1 commit into from
May 23, 2022

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented May 22, 2022

Avoid side effect behavior by explicitly passing the ScrypeType to the
collector.

Signed-off-by: SuperQ superq@gmail.com

Avoid side effect behavior by explicitly passing the ScrypeType to the
collector.

Signed-off-by: SuperQ <superq@gmail.com>
Copy link
Member

@rustycl0ck rustycl0ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 5251391 into master May 23, 2022
@SuperQ SuperQ deleted the superq/refactor_types branch May 23, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants