Grab Timestamps from Metric #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janphkre
force-pushed
the
feature/metrric_timestamp
branch
3 times, most recently
from
7a7378b
to
9420b27
Compare
based on prometheus-community#97 and prometheus-community#80 this provides the posibility to use a metric that has a unix style timestamp as the timestamp of the scraped metric When deserializing objects we need to take the key json path into account as well like we would do for all the values as well. This allows collections to be defined still with each entry having a separate timestamp (e.g. list of time-stamped log messages). Update examples for timestamp Update Readme about staleness for custom timestamps Signed-off-by: Jan Phillip Kretzschmar <janphkre@gmx.de>
janphkre
force-pushed
the
feature/metrric_timestamp
branch
from
9420b27
to
c0d3da9
Compare
sysadmind
approved these changes
Aug 25, 2022
SuperQ
requested changes
Aug 26, 2022
|
Minor documentation correction. |
Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
approved these changes
Aug 28, 2022
Merged
raedtwj
pushed a commit
to raedtwj/json_exporter
that referenced
this pull request
Sep 13, 2023
* [FEATURE] Allow timestamps from metrics prometheus-community#167 * [FEATURE] Support Value Conversions prometheus-community#172 Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: raed altuwaijri <altuwaijriraed@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I want to follow up on #97 after following along the discussion in #80.
I was lacking this functionality, as i was scraping broadcasted messages from a server that supplies the most recent message with a timestamp. (https://github.com/john30/ebusd/wiki/3.2.-HTTP-client)
I hope the code is up to spec as I am really not familiar with go.