Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization: Use dict setdefault to replace if key in dict #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimization: Use dict setdefault to replace if key in dict #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 14 additions & 16 deletions deleted_libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,18 @@ def main():
for line in file:
part = line.decode().strip().split()

if len(part) == 7:
library = part[5]
comment = part[6]

if '/lib/' in library and '(deleted)' in comment:
if path not in processes_linking_deleted_libraries:
processes_linking_deleted_libraries[path] = {}

if library in processes_linking_deleted_libraries[path]:
processes_linking_deleted_libraries[path][library] += 1
else:
processes_linking_deleted_libraries[path][library] = 1
if len(part) != 7:
continue
library = part[5]
comment = part[6]

if '/lib/' in library and '(deleted)' in comment:
if path not in processes_linking_deleted_libraries:
processes_linking_deleted_libraries[path] = {}

processes_linking_deleted_libraries[path].setdefault(library, 0)
processes_linking_deleted_libraries[path][library] += 1

except EnvironmentError as e:
# Ignore non-existent files, since the files may have changed since
# we globbed.
Expand All @@ -50,10 +50,8 @@ def main():
continue

libraries_seen.add(library)
if library in num_processes_per_library:
num_processes_per_library[library] += 1
else:
num_processes_per_library[library] = 1
num_processes_per_library.setdefault(library, 0)
num_processes_per_library[library] += 1

registry = CollectorRegistry()
g = Gauge('node_processes_linking_deleted_libraries',
Expand Down