Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartmon.py: fix parse error #41

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Conversation

paol
Copy link
Contributor

@paol paol commented Mar 4, 2020

Some device models report "---" in the threshold value where most devices would report "000".
This was crashing the program with a parse exception.

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@SuperQ
Copy link
Contributor

SuperQ commented Oct 3, 2020

Can you rebase this against the latest version?

Some device models report "---" in the threshold value where most devices would report "000".
This was crashing the program with a parse exception.

Signed-off-by: Pedro Lopes <paol@draic.org>
@dswarbrick dswarbrick merged commit b9a2565 into prometheus-community:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants