feat: Add safe_wal_size and wal_status to replication_slot #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcWort
force-pushed
the
mwn-replication-safe-status
branch
from
5faa9e8
to
4e4a729
Compare
SuperQ
requested changes
May 7, 2024
Signed-off-by: MarcWort <113890636+MarcWort@users.noreply.github.com>
Signed-off-by: MarcWort <113890636+MarcWort@users.noreply.github.com>
MarcWort
force-pushed
the
mwn-replication-safe-status
branch
from
4e4a729
to
7525c2a
Compare
|
|
|
Also, why are the |
ringerc
reviewed
Jun 10, 2024
Comment on lines
+95
to
+96
| safe_wal_size, | ||
| wal_status |
There was a problem hiding this comment.
These were added in postgres 13, they are absent in 12 and below, so this will break scraping on Pg 12. See https://www.postgresql.org/docs/12/view-pg-replication-slots.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #1017