Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary handler allocations #47

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Remove unnecessary handler allocations #47

merged 1 commit into from
Jun 6, 2023

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Jun 6, 2023

Cleanup unnecessary creation of handler vars for various event handlers.

@SuperQ
Remove unnecessary handler allocations
cee31bd 
Cleanup unnecessary creation of `handler` vars for various event
handlers.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ
Copy link
Contributor Author

SuperQ commented Jun 6, 2023

CC @floatingstatic

@SuperQ SuperQ requested a review from metalmatze June 6, 2023 10:19
matthiasr
matthiasr approved these changes Jun 6, 2023
View reviewed changes
Copy link

@matthiasr matthiasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these would be causing actual allocations, they should all be on the stack, but nonetheless it reads better this way 😄

@SuperQ SuperQ merged commit 0ce0e4e into main Jun 6, 2023
5 checks passed
@SuperQ SuperQ deleted the superq/rm_handler branch June 6, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasr matthiasr matthiasr approved these changes

@metalmatze metalmatze Awaiting requested review from metalmatze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperQ @matthiasr