Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use golden file for tests #211

Merged

Conversation

simonpasquier
Copy link
Contributor

Modifying existing tests for alerts and rules endpoints is very tedious as you need to do lots of manual edits. This change relies on golden files which can be automatically updated as the reponse payload evolves.

Modifying existing tests for alerts and rules endpoints is very tedious
as you need to do lots of manual edits. This change relies on golden
files which can be automatically updated as the reponse payload evolves.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

@squat squat merged commit 947a0b4 into prometheus-community:main Apr 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants