fix: support regex for non-query endpoints #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpasquier
force-pushed
the
update-regex-match-support
branch
from
4d96d8f
to
a0f3326
Compare
|
@simonpasquier Thanks for this PR. lgtm! |
squat
reviewed
Jun 11, 2024
| @@ -378,6 +378,9 @@ func NewRoutes(upstream *url.URL, label string, extractLabeler ExtractLabeler, o | |||
| "/api/v1/rules": modifyAPIResponse(r.filterRules), | |||
| "/api/v1/alerts": modifyAPIResponse(r.filterAlerts), | |||
| } | |||
| //FIXME: when ModifyResponse returns an error, the default ErrorHandler is | |||
| //called which returns 502 Bad Gateway. It'd be more appropriate to treat | |||
| //the error and return 400 in case of bad input for instance. | |||
squat
reviewed
Jun 11, 2024
squat
approved these changes
Jun 11, 2024
PR prometheus-community#171 implemented support for regex label values but only for the query endpoints. This change adds support for all other Prometheus API endpoints. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
update-regex-match-support
branch
from
a0f3326
to
371b506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #171 implemented support for regex label values but only for the query endpoints. This change adds support for all other Prometheus API endpoints.
FYI @sathieu. I remember that we discussed about the issue with the Alertmanager API endpoints but nothing about the non-query Prometheus endpoints. Let me know if the change looks sane.