Update docker repo #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
metalmatze
approved these changes
Oct 24, 2018
s-urbaniak
reviewed
Oct 24, 2018
| @@ -7,7 +7,7 @@ OUT_DIR=_output | |||
| BIN?=prom-label-proxy | |||
| VERSION?=$(shell cat VERSION) | |||
| PKGS=$(shell go list ./... | grep -v /vendor/) | |||
| DOCKER_REPO?=quay.io/openshift/prom-label-proxy | |||
| DOCKER_REPO?=quay.io/coreos/prom-label-proxy | |||
There was a problem hiding this comment.
silly question: shouldn't these all be openshift?
There was a problem hiding this comment.
silly answer: I don't have permission to create repos under that, this seemed like the path of least resistance.
s-urbaniak
approved these changes
Oct 24, 2018
|
you will be assimilated |
nima-rx
added a commit
to snapp-incubator/prom-label-proxy
that referenced
this pull request
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the docker repo on quay and pushed the current state of this repo to it, so we can move forward with testing. Once this is merged I would tag the v0.1.0 tag on this repo and branch a
release-0.1branch.@metalmatze @s-urbaniak