Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reported Data bytes Read/Written on SSDs #138

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

tekert
Copy link
Contributor

@tekert tekert commented Jul 25, 2023

This value is reported in thousands (i.e., a value of 1 corresponds to 1000 units of 512 bytes written) and is rounded up.
When the LBA size is a value other than 512 bytes, the controller shall convert the amount of data written to 512 byte units.

Current code is using 1024 instead of 1000.

	 This value is reported in thousands (i.e., a value of 1 corresponds to 1000 units of 512 bytes written) and is rounded up.
	 When the LBA size is a value other than 512 bytes, the controller shall convert the amount of data written to 512 byte units.

Current code is using 1024 instead of 1000.

Signed-off-by: tekert <tekert@gmail.com>
@k0ste
Copy link
Contributor

k0ste commented Jul 29, 2023

@SuperQ

@NiceGuyIT NiceGuyIT mentioned this pull request Aug 10, 2023
@NiceGuyIT
Copy link
Member

Thanks @tekert! For reference, the link to the smartctl source is at the bottom of this comment.

@NiceGuyIT NiceGuyIT merged commit e5bf7aa into prometheus-community:master Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants