Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metricDeviceCount gauge name #147

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix metricDeviceCount gauge name #147

merged 1 commit into from
Aug 16, 2023

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Aug 16, 2023

Prometheus naming conventions reserve _count for the counter in histograms. For gauge values the naming convention is to use the plural of the thing being counted.

@SuperQ
Fix metricDeviceCount gauge name
d5fb66c 
Prometheus naming conventions reserve `_count` for the counter in
histograms. For gauge values the naming convention is to use the plural
of the thing being counted.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ requested a review from NiceGuyIT August 16, 2023 07:22
@NiceGuyIT
Copy link
Member

For reference: https://prometheus.io/docs/instrumenting/writing_exporters/#metrics

@NiceGuyIT NiceGuyIT merged commit e9ef093 into master Aug 16, 2023
6 checks passed
@NiceGuyIT NiceGuyIT deleted the superq/fix_gauge_name branch August 16, 2023 23:44
@k0ste k0ste mentioned this pull request Aug 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiceGuyIT NiceGuyIT Awaiting requested review from NiceGuyIT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperQ @NiceGuyIT