Update json reading logging #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer to keep it a single log line, at the end, with |
|
Sure, that's also fine. |
Update the smartctl command reading and parsing of json logging to make for easier debugging of slow devices by adding a duration to the debug logging. For #197 Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/debug_timing
branch
from
e21dbef
to
32de524
Compare
zxzharmlesszxz
pushed a commit
to zxzharmlesszxz/smartctl_exporter
that referenced
this pull request
Mar 5, 2024
Update the smartctl command reading and parsing of json logging to make for easier debugging of slow devices by adding a duration to the debug logging. For prometheus-community#197 Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: mort <mort@syneforge.com>
zxzharmlesszxz
pushed a commit
to zxzharmlesszxz/smartctl_exporter
that referenced
this pull request
Mar 5, 2024
Update the smartctl command reading and parsing of json logging to make for easier debugging of slow devices by adding a duration to the debug logging. For prometheus-community#197 Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: Denys <zxzharmlesszxz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the smartctl command reading and parsing of json logging to make for easier debugging of slow devices by adding a duration to the debug logging.
For #197