Bugfix - Failure due duplicated records in statistic tables

[vagifzeynalov]

#3

[lahwaacz]

So this adds an artificial statistic_table_row label to disambiguate the duplicates. But the label is entirely artificial, it does not correspond to anything exported by smartctl (see #3 (comment) which shows the problematic Vendor Specific Statistics). Artificial labels are useless for other statistics tables which were already unambiguous. Moreover, if smartctl or the smartctl_exporter change the order in which the statistic tables are produced or processed, the statistic_table_row numbering will be messed up in Prometheus. Note that this change is already backwards incompatible, since Prometheus will treat the same thing before and after this change as two different metrics, because they have different labels.

Do you have a specific use case for the Vendor Specific Statistics? If yes, they should be made sense of in a different way that does not affect other statistic_table_row metrics. If not, let's just ignore them – #28.

[vagifzeynalov]

Hi @lahwaacz
Thanks for your comment, I completely agree with you.
Frankly speaking I'm not looked too careful at the origins of those values. The goal was to fix it quick (and apparently slightly dirty) 😁
I'll review them more carefully on the weekend.

[vagifzeynalov]

closing for now