Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device filtering #99

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Add device filtering #99

merged 1 commit into from
Dec 9, 2022

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Nov 30, 2022

  • Add device include/exclude filters for the automatic scanning.
  • Refactor scanning to not scan if devices are manually specified.
  • Don't try and filter manually specified devices.

Closes: #97

Signed-off-by: SuperQ superq@gmail.com

Copy link

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds reasonable to me.

It break the current behaviour but that's for the best from my opinion

@Nexucis
Copy link

Nexucis commented Dec 8, 2022

can you update the readme with the new flag @SuperQ ?

* Add device include/exclude filters for the automatic scanning.
* Refactor scanning to not scan if devices are manually specified.
* Don't try and filter manually specified devices.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ
Copy link
Contributor Author

SuperQ commented Dec 9, 2022

Done, updated the README.

@SuperQ SuperQ merged commit 2df95c8 into master Dec 9, 2022
@SuperQ SuperQ deleted the superq/filter branch December 9, 2022 21:04
@xelnagamex
Copy link

Thanks for merging this! When will this feature be released?

@k0ste k0ste mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to exclude device from smartctl scan
3 participants