Service Api collection close servicehandler to avoid memory leak

Signed-off-by: Alvaro Cabanas <acabanas@newrelic.com>
prometheus-community · Sep 23, 2021 · f4f5aaf · f4f5aaf
1 parent 5931604
commit f4f5aaf
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/collector/service.go b/collector/service.go
@@ -246,18 +246,17 @@ func (c *serviceCollector) collectAPI(ch chan<- prometheus.Metric) error {
 		if err != nil {
 			continue
 		}
+		defer serviceHandle.Close()
 
 		// Get Service Configuration
 		serviceConfig, err := serviceHandle.Config()
 		if err != nil {
-			_ = serviceHandle.Close()
 			continue
 		}
 
 		// Get Service Current Status
 		serviceStatus, err := serviceHandle.Query()
 		if err != nil {
-			_ = serviceHandle.Close()
 			continue
 		}