Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.25.X ignore enable_iis_worker_process #1390

Closed
rivoalrivoal opened this issue Jan 17, 2024 · 5 comments
Closed

Version 0.25.X ignore enable_iis_worker_process #1390

rivoalrivoal opened this issue Jan 17, 2024 · 5 comments
Labels

Comments

@rivoalrivoal
Copy link

rivoalrivoal commented Jan 17, 2024

Hello

Since version 0.25, the w3wp doesn't have IIS Site name because of the EnableWorkerProcess variable.
But, this variable doesn't work.

It's not because there are "kingpin" and not "app" here ?

https://github.com/prometheus-community/windows_exporter/blob/master/pkg/collector/process/process.go#L93C24-L93C31

My config file

collectors:
  enabled: cache,cpu,cpu_info,cs,iis,logical_disk,logon,memory,netframework_clrexceptions,netframework_clrinterop,netframework_clrjit,netframework_clrloading,netframework_clrlocksandthreads,netframework_clrmemory,netframework_clrremoting,netframework_clrsecurity,net,os,process,service,tcp,time,smtp

collector:
  process:
    enable_iis_worker_process: true
@rivoalrivoal rivoalrivoal changed the title Version 0. Version 0.25.X ignore enable_iis_worker_process Jan 17, 2024
@kago-dk
Copy link

kago-dk commented Jan 19, 2024

And the windows_exporter --help does not indicate the option.

@DiniFarb
Copy link
Contributor

Yes that seems to be the issue: https://github.com/prometheus-community/windows_exporter/blob/master/pkg/collector/process/process.go#L93C24-L93C31 should be app.Flag

But also just to mention, your config file should be:

collectors:
  enabled: cache,cpu,cpu_info,cs,iis,logical_disk,logon,memory,netframework_clrexceptions,netframework_clrinterop,netframework_clrjit,netframework_clrloading,netframework_clrlocksandthreads,netframework_clrmemory,netframework_clrremoting,netframework_clrsecurity,net,os,process,service,tcp,time,smtp

collector:
  process:
      iis: true

@breed808 I am going to create a PR to fix this. Ok ?

@breed808
Copy link
Contributor

Yep, go right ahead. I'm happy to review.

DiniFarb added a commit to DiniFarb/windows_exporter that referenced this issue Jan 29, 2024
DiniFarb added a commit to DiniFarb/windows_exporter that referenced this issue Jan 29, 2024
Signed-off-by: dinifarb <andreas.vogt89@bluewin.ch>
breed808 added a commit that referenced this issue Jan 29, 2024
fix(#1390): global kingpin instead of app var
webalexeu pushed a commit to webalexeu/windows_exporter that referenced this issue Feb 16, 2024
Signed-off-by: dinifarb <andreas.vogt89@bluewin.ch>
Signed-off-by: Alexandre JARDON <28548335+webalexeu@users.noreply.github.com>
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Apr 29, 2024
@jkroepke
Copy link
Member

Fixed in #1397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants