Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/ should serve some welcome page instead of redirecting #25

Closed
carlpett opened this issue Sep 17, 2016 · 1 comment
Closed

/ should serve some welcome page instead of redirecting #25

carlpett opened this issue Sep 17, 2016 · 1 comment
Labels

Comments

@carlpett
Copy link
Collaborator

Currently we do a redirect from / to /metrics. Drawback to this is that there is no request that can be done to check that everything is alright (http server is working, at least) without also incurring the cost of running the wmi queries.

Our use case is that we have / as a http healthcheck endpoint for exporters which we register in Consul. If we want to keep the redirect, we should have some endpoint which indicates that things are ok, at least.

@martinlindhe
Copy link
Collaborator

I've personally no real opinion on this one. The redirect / -> metrics came while copying boilerplate code (from node_exporter, or one of the other exporters. Don't remember).

If a simple health check page is useful, perhaps put it on /health, rather than on the root?

martinlindhe added a commit that referenced this issue Sep 27, 2016
exporter: add /health endpoint. fixes #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants