Remove init functions from collectors #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breed808
force-pushed
the
remove_init
branch
2 times, most recently
from
98112b9
to
5d16571
Compare
|
This needs a DCO sign-off. You can use |
Behaviour of init functions has been centralised in `collector/init.go`, and can be called during exporter startup. This allows the exporter to control the timing of collector initialisation, rather than relying on the import & `init()` method. This should reduce unexpected behaviour arising from the use of `init()`, such as prometheus-community#551. Signed-off-by: Ben Reedy <breed808@breed808.com>
Collector builder functions are only used internally in the `collector` package, and shouldn't needlessly be exposed as part of the package API to downstream clients. Signed-off-by: Ben Reedy <breed808@breed808.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behaviour of init functions has been centralised in
collector/init.go,and can be called during exporter startup. This allows the exporter to
control the timing of collector initialisation, rather than relying on
the import &
init()method.This should reduce unexpected behaviour arising from the use of
init(), such as #551.