Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml for WS2022 nodes #1189

Merged

Conversation

vrapolinario
Copy link
Contributor

Adding a yaml spec with an image supported on Windows Server 2022 nodes.

@vrapolinario vrapolinario requested a review from a team as a code owner April 17, 2023 18:55
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. The 2022 manifest appears to be identical to the existing manifest, except for the image tag.

I don't think the level of duplication here is ideal, but the complexity of the manifests isn't enough to warrant a helm chart (not that I could support one anyway).

Do you think it would be worth updating the tag in the existing manifest?

@vrapolinario
Copy link
Contributor Author

That would be a solution for WS2022 nodes - hopefully that's what people are using these days, but then it becomes a problem for people running WS2019, hence my proposal for a separate file.

@breed808
Copy link
Contributor

Just so I understand correctly, for windows containers the image and node must match? I.E. a Windows 2019 node cannot run 2022 container images?

@vrapolinario
Copy link
Contributor Author

That is correct. And the images are version specific.

@vrapolinario
Copy link
Contributor Author

@breed808
Copy link
Contributor

Thanks for enlightening me on this, I wasn't aware of the Windows container/host restrictions. If you sign the commit (to pass the DCO check) I'll get this merged.

@vrapolinario
Copy link
Contributor Author

vrapolinario commented Apr 18, 2023

#signed-off-by: Vinicius Apolinario viniap@microsoft.com

@breed808
Copy link
Contributor

@vrapolinario you'll need to sign the commit with git commit --amend --no-edit -s. You can open the DCO details link for more info on the signing.

Signed-off-by: vrapolinario <viniap@microsoft.com>
@vrapolinario
Copy link
Contributor Author

vrapolinario commented Apr 26, 2023

Sorry for the delay - KubeCon and all. I have just signed the commit following the instructions. Apologies as my Git abilities are very limited. :)

Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem, thanks for updating it.

@breed808 breed808 merged commit f19fa77 into prometheus-community:master Apr 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants