fix: Update init container in windows exporter so that it works on both WS2019 and WS2022 #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI, my AKS clusters that I mention in MicrosoftDocs/azure-docs#112066 are only based on WS 2022 |
breed808
approved these changes
Jul 14, 2023
…th WS2019 and WS2022 Signed-off-by: Kaveesh Dubey <kadubey@microsoft.com>
|
Thanks @breed808 I have signed off on the commit. Please take a look when you get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cluster can container multiple nodepools with both WS 2019 and WS 2022.
Deploying both the YAML's on one's cluster will leave some containers always in the init creation phase with errors. I have switched the init container to use the powershell ltsc nanoserver image which works on both WS 2019 and WS 2022 so that one daemonset deployment is enough.