Add new counter LDAP Client Sessions #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First time contributing here, so please let me know what else is required. Thanks |
|
@breed808 is there anything else required here? |
breed808
reviewed
Sep 4, 2023
Signed-off-by: Mark Dordoy <mdordoy@palantir.com>
…antir.com> Signed-off-by: Mark Dordoy <mdordoy@palantir.com>
Signed-off-by: Mark Dordoy <mdordoy@palantir.com>
Signed-off-by: Mark Dordoy <mdordoy@palantir.com>
Signed-off-by: Mark Dordoy <mdordoy@palantir.com>
|
@breed808 updated based on comments. Think i've fixed linting, but will need workflows to run to confirm. |
|
Nice, thank you @breed808 Whats the process for this to make it to the next version of the grafana agent? |
|
This change will be made available in the next windows_exporter release. If the Grafana Agent is pinned to a particular windows_exporter version, the agent would need to update the dependency. I'll aim to have a new release for the exporter done in the next week. |
|
Thanks @breed808 Looks like the agent needs an update, PR here: grafana/agent#5088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very handy metric to observe. If you hit your hard limit (5000 by default) connections start to drop off. Its a good indicator to know there is a bad LDAP Client connecting to your directory