Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Add textfile to enabled_collectors #1345

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

breed808
Copy link
Contributor

Omission of the collector implied that setting TEXTFILE_DIR was sufficient to enable the collector, which is not true.

Resolves #1344

Omission of the collector implied that setting `TEXTFILE_DIR` was
sufficient to enable the collector, which is not true.

Signed-off-by: Ben Reedy <breed808@breed808.com>
@breed808 breed808 requested a review from a team as a code owner November 20, 2023 10:02
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@breed808 breed808 merged commit ac93033 into prometheus-community:master Nov 20, 2023
2 checks passed
@breed808 breed808 deleted the readme_textfile branch November 20, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md example implies TEXTFILE_DIR flag enables textfile collector
2 participants