Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Provide binary builds from GH actions #1377

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Jan 8, 2024

This PR uploads the windows_exporter.exe file from job lint as job artifact.

It give us the opportunity the ask different users, if PR like #1376 solves issues. Before this, users have build own exporter binaries which could be a blocker for inexperienced users.

@jkroepke jkroepke force-pushed the ci-exe branch 2 times, most recently from faab30c to 44f55d3 Compare January 8, 2024 18:24
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke marked this pull request as ready for review January 8, 2024 18:32
@jkroepke jkroepke requested a review from a team as a code owner January 8, 2024 18:32
@jkroepke
Copy link
Member Author

jkroepke commented Jan 8, 2024

Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jkroepke jkroepke merged commit f260a8f into prometheus-community:master Jan 9, 2024
5 checks passed
@jkroepke jkroepke deleted the ci-exe branch January 9, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants