Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label user to process collector #1472

Merged

Conversation

aburtasov
Copy link
Contributor

@aburtasov aburtasov commented May 8, 2024

Added label "user" to process collector. Using WIN32_LoggedOnUser and Win32_SessionProcess

Example metric with new label:

HELP windows_process_cpu_time_total Returns elapsed time that all of the threads of this process used the processor to execute instructions by mode (privileged, user).
TYPE windows_process_cpu_time_total counter
windows_process_cpu_time_total{creating_process_id="12244",mode="privileged",process="powershell",process_id="17512",user="MYDOMAIN\aburtasov"} 0.296875
windows_process_cpu_time_total{creating_process_id="12244",mode="privileged",process="powershell",process_id="19688",user="MYDOMAIN\aburtasov"} 14.296875
windows_process_cpu_time_total{creating_process_id="12244",mode="privileged",process="powershell",process_id="25612",user="MYDOMAIN\aburtasov"} 0.484375

Signed-off-by: Andrey Burtasov <andrey.a.burtasov@gmail.com>
@aburtasov aburtasov requested a review from a team as a code owner May 8, 2024 10:52
@jkroepke jkroepke added this to the v0.26.0 milestone May 11, 2024
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR on my local system and it works.

However, I see that the collector is 10 times slower compared to master branch.

master:
windows_exporter_collector_duration_seconds{collector="process"} 0.0121184

PR:
windows_exporter_collector_duration_seconds{collector="process"} 0.1610989

Thats to much. I have provide some suggestions, I hope they help. After apply the suggestion, verify locally, if everything still works as expected.

pkg/collector/process/process.go Outdated Show resolved Hide resolved
pkg/collector/process/process.go Outdated Show resolved Hide resolved
pkg/collector/process/process.go Outdated Show resolved Hide resolved
pkg/collector/process/process.go Outdated Show resolved Hide resolved
pkg/collector/process/process.go Outdated Show resolved Hide resolved
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR on my local system and it works.

However, I see that the collector is 10 times slower compared to master branch.

master:
windows_exporter_collector_duration_seconds{collector="process"} 0.0121184

PR:
windows_exporter_collector_duration_seconds{collector="process"} 0.1610989

Thats to much. I have provide some suggestions, I hope they help. After apply the suggestion, verify locally, if everything still works as expected.

Signed-off-by: Andrey Burtasov <andrey.a.burtasov@gmail.com>
@aburtasov
Copy link
Contributor Author

@jkroepke After the changes, it still works, but I'm not sure it improved the speed

@jkroepke
Copy link
Member

jkroepke commented Jun 7, 2024

Hey @aburtasov

I looked into it and in term of performance, it overhead compared to the first version is low now.

However, I would also looked into it, if I can avoid the WMI query. Thats something, what I will looked into it.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
Copy link
Member

jkroepke commented Jun 7, 2024

Please take a look, if it still works for you.

@aburtasov
Copy link
Contributor Author

@jkroepke Hi!

I tried the new version with your latest commit. There is no "user" label. Do I understand correctly, you want to optimize the process of adding the "user" label?

@jkroepke
Copy link
Member

Hey @aburtasov

the feature is now optional, behind a toggle --collector.process.report-owner

@aburtasov
Copy link
Contributor Author

@jkroepke Good job. Everything works correctly.

@jkroepke jkroepke merged commit 4efb502 into prometheus-community:master Jun 17, 2024
6 checks passed
@aburtasov aburtasov deleted the feature/collector/process branch June 20, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants