MSI parameter - EXTRA_FLAGS

[kpettijohn]

Added the ENABLED_COLLECTOR_SERVICE_FILTERS parameter to the MSI installer in order to allow specifying a custom service query (collector.service.services-where).

Example:

msiexec /i wmi_exporter-0.5.1-amd64.msi ENABLED_COLLECTORS="service" ENABLED_COLLECTOR_SERVICE_FILTERS="""Name LIKE 'sql%'"""

Overall this is a rough attempt (I'm not familiar with MSI/windows packaging) at addressing #170.

[carlpett]

Thanks @kpettijohn!
I was thinking about if it would make sense to just have a EXTRA_FLAGS parameter instead, so we don't need to do this for every flag to the exporter, what do you think?

[kpettijohn]

@carlpett sounds good! I believe I have things working with the EXTRA_FLAGS parameter now after fighting with how quoting/escaping is being handled.

Example:

msiexec /log C:\pkg_install.log /i wmi_exporter-0.5.0-amd64.msi ENABLED_COLLECTORS=cpu,cs,net,os,service,system --% EXTRA_FLAGS="--collector.service.services-where ""Name LIKE 'sql%'"""

Let me know if you need any changes!

[carlpett]

Nice! The --% thing looks interesting, what does it mean? 😄
It'd be great with a short mention of this in the README file, too, but otherwise looks good!

[kpettijohn]

The stop-parsing symbol (--%) prevents PowerShell from interpreting arguments in program calls as PowerShell commands and expressions.

https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_special_characters?view=powershell-6#stop-parsing----

https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_parsing?view=powershell-6

Im not very familiar with PowerShell but it seemed required to use --% in order to prevent spaces/quotes/symbols in the EXTRA_FLAGS parameter from being interpreted incorrectly.

[carlpett]

Thanks!