Correct layout of SystemInfo structs #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g read Signed-off-by: Ben Ridley <benridley29@gmail.com>
carlpett
approved these changes
May 21, 2021
|
I have downloaded windows exporter version 0.16.0 from assets section. Few matrices like windows_system_system_up_time getting no values after installing. Please advise. |
|
Hi @ravpatiltibco, the System uptime metric is collected differently to the metrics concerned in this PR. From first glance it appears its using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the layout of the SystemInfo structs which previously had a field that was too small, causing the struct to return the wrong values after being modified by the WinAPI function.
Signed-off-by: Ben Ridley benridley29@gmail.com