Add missing Process Collector metrics #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working Set Private and Working Set Peak were being collected, but not exposed by the exporter. Signed-off-by: Ben Reedy <breed808@breed808.com>
Signed-off-by: Ben Reedy <breed808@breed808.com>
Signed-off-by: Ben Reedy <breed808@breed808.com>
carlpett
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
windows_process_working_set_private_bytesandwindows_process_working_set_peak_bytesmetrics, which were previously being collected but not exposed.I've also moved the collector metric documentation to the collector's markdown file, leaving a less-verbose description in each metric definition.
Finally, the
windows_process_working_setmetric has been renamed towindows_process_working_set_bytesto keep in line with the Prometheus metric naming best practices.Resolves #797