Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set relative default path for textfile collector #848

Merged
merged 1 commit into from Oct 23, 2021
Merged

Set relative default path for textfile collector #848

merged 1 commit into from Oct 23, 2021

Conversation

ArtamonovEvgenii
Copy link

Hello

Issue: #847

I changed the default value of collector.textfile.directory. Now it is relative to .exe file and equal %exepath%\textfile_inputs

@ArtamonovEvgenii ArtamonovEvgenii requested a review from a team as a code owner October 3, 2021 18:22
carlpett
carlpett approved these changes Oct 17, 2021
View reviewed changes
Copy link
Collaborator

@carlpett carlpett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Evgenyi,
Thanks, this does make sense! Not sure why we didn't implement it like this initially. Only change I see needed would be to sign the DCO, let us know if you need any help there.
@breed808 I think this would be fine from a backwards compatibility perspective, do you agree?

@ArtamonovEvgenii
Set relative default path for textfile collector
d0cfc14 
Signed-off-by: Artamonov Evgenii <evgenyi.artamonov@gmail.com>
@breed808
Copy link
Contributor

@breed808 I think this would be fine from a backwards compatibility perspective, do you agree?

Yes, this looks fine 👍

@breed808 breed808 merged commit 75966fd into prometheus-community:master Oct 23, 2021
@breed808 breed808 mentioned this pull request Oct 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlpett carlpett carlpett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArtamonovEvgenii @breed808 @carlpett