This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
index: Fast path for EmptyPostings cases in Merge, Intersect and Without #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
emptypostings-v2
branch
from
97e03ba
to
2529952
Compare
|
ping @gouthamve |
|
@bwplotka I did a PR against your branch with few adjustments. |
|
LGTM, Thanks! |
|
@codesome want to have a quick look before I merge it? |
|
ping @bwplotka |
bwplotka
force-pushed
the
emptypostings-v2
branch
from
7ec75b4
to
a1c10d2
Compare
|
Updated @krasi-georgiev and @codesome Thanks for ping & reviews. Ping me directly on IRC or slack if you want my review/PR update I am flooded with GH notifications ): I changed a lot now, because of conflicts - I rewrote test cases to make more sense, let me know if that is OK with you guys. |
bwplotka
force-pushed
the
emptypostings-v2
branch
2 times, most recently
from
320e690
to
d9478d4
Compare
bwplotka
force-pushed
the
emptypostings-v2
branch
from
d9478d4
to
ea11a9c
Compare
Improved Merge when all is empty. Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
emptypostings-v2
branch
from
ea11a9c
to
2aec9a9
Compare
|
Thanks Bartek! |
|
Thanks Krasi (: |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates old #233 onto fresh TSDB code.
closes #233