Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go 1.18 and latest golangci #311

Merged
merged 1 commit into from Apr 4, 2023
Merged

Use go 1.18 and latest golangci #311

merged 1 commit into from Apr 4, 2023

Conversation

zhan9san
Copy link
Collaborator

@zhan9san zhan9san commented Apr 3, 2023 •
edited

Go 1.18 is required in direct dependency github.com/prometheus/alertmanager and indirect dependency github.com/cenkalti/backoff/v4.

module github.com/prometheus/alertmanager
go 1.18

module github.com/cenkalti/backoff/v4
go 1.18

Related to
#298 #301 #310

@zhan9san zhan9san requested a review from kbudde April 3, 2023 20:02
kbudde
kbudde approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@kbudde kbudde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like what you are doing 👍

@zhan9san zhan9san merged commit fe1e3af into prometheus-msteams:master Apr 4, 2023
2 checks passed
@zhan9san
Copy link
Collaborator Author

zhan9san commented Apr 4, 2023

Very glad to hear that.😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbudde kbudde kbudde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhan9san @kbudde