Templating #37
Merged
Templating #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it easier handling multiple prometheus alerts. Previously we combined multiple alerts to a single teams message card, where we need to handle to large teams messages. In this approach, we make it simpler by not combining multiple prometheus alerts to a single teams message card as this might not be possible anymore with templating, as you would need to parse the json and thus loosing the flexibility that we want to gain with the templating approach
|
FYI: The current status is still very in progress as unit testing does not work at all and lots of old code snippets have been commented out...please ignore that for now :D . See #12 for more information about my thoughts and issues... |
|
Open ToDos:
|
Closed
… backwards compatibility
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
===========================================
+ Coverage 43.22% 58.64% +15.42%
===========================================
Files 2 2
Lines 118 162 +44
===========================================
+ Hits 51 95 +44
+ Misses 65 63 -2
- Partials 2 4 +2
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first draft for #12 . I did some research how to implement this and I think it would be good to use the Prometheus Alertmanager templating. It makes sense as prometheus-msteams is based on alertmanager and furthermore, end users might be more comfortable using alertmanager templating where they can use pre-defined functions etc.
There are some stuff still missing that I need to implement:
@bzon it would be great if you can have a look into it and tell me what you think.