Silence alerts #66
Merged
Silence alerts #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 70.16% 70.16%
=======================================
Files 2 2
Lines 181 181
=======================================
Hits 127 127
Misses 48 48
Partials 6 6Continue to review full report at Codecov.
|
|
@sosoriov thanks for this contribution. In general it looks really good, but I would not put it to the Readme of the root project but rather create an additional Readme in the examples folder in order to not pollute the main Readme. It is already referenced in the root Readme, so this part should be fine. |
|
@Knappek I changed the code included your suggestion. Let me know your comments! |
|
/lgtm |
bzon
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New template with Silence action #62