-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: add example usage of prometheus-agent #1472
Conversation
Signed-off-by: paulfantom <pawel@krupa.net.pl>
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
Do you want to enable us to work on your fork to get this one done? 🙂 |
The "Allow edits and access to secrets by maintainers" checkbox is checked, so you should've been able to work on this 🤔 |
Hmmm that's awkward 😕 I've opened a pull request to your fork. We still need some work left though, after running the agent in a cluster I've got this error:
|
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
I've created another PR to your fork :) |
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
Yet another PR to your fork 😬 |
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
One last nit in form of removing prometheus version pinning (the whole project is already at 2.32+). I think this is ready to go. @ArthurSens @philipgough could you take one more look and possibly merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
PoC for running prometheus-agent with kube-prometheus.
NOTE: I do not have time to finalize this, so I welcome everyone wants to step up and finish this PR.
What needs to be improved:
alerting
config section fromprometheus
object.Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.