Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add example usage of prometheus-agent #1472

Merged
merged 10 commits into from
Jan 7, 2022

Conversation

paulfantom
Copy link
Member

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

PoC for running prometheus-agent with kube-prometheus.

NOTE: I do not have time to finalize this, so I welcome everyone wants to step up and finish this PR.

What needs to be improved:

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.

example of running prometheus-agent with kube-prometheus

paulfantom and others added 2 commits November 2, 2021 09:58
Signed-off-by: paulfantom <pawel@krupa.net.pl>
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
@paulfantom
Copy link
Member Author

@ArthurSens
Copy link
Member

Do you want to enable us to work on your fork to get this one done? 🙂

@paulfantom
Copy link
Member Author

The "Allow edits and access to secrets by maintainers" checkbox is checked, so you should've been able to work on this 🤔

@ArthurSens
Copy link
Member

ArthurSens commented Nov 29, 2021

Hmmm that's awkward 😕

image

I've opened a pull request to your fork.

We still need some work left though, after running the agent in a cluster I've got this error:

ts=2021-11-29T16:05:15.753Z caller=main.go:195 level=info msg="Experimental agent mode enabled."
The following flag(s) can not be used in agent mode: ["--storage.tsdb.path" "--storage.tsdb.retention.time"]

@ArthurSens
Copy link
Member

I've created another PR to your fork :)

@ArthurSens
Copy link
Member

Yet another PR to your fork 😬

@paulfantom
Copy link
Member Author

One last nit in form of removing prometheus version pinning (the whole project is already at 2.32+).

I think this is ready to go. @ArthurSens @philipgough could you take one more look and possibly merge this?

@paulfantom paulfantom changed the title WIP: examples: add example usage of prometheus-agent examples: add example usage of prometheus-agent Jan 4, 2022
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side.

@paulfantom paulfantom merged commit b2a250f into prometheus-operator:main Jan 7, 2022
@paulfantom paulfantom deleted the prom-agent branch January 7, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants