Adds readinessProbe and livenessProbe to prometheus-adapter jsonnet #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jsonnet/kube-prometheus/components/prometheus-adapter.libsonnet
Outdated
Show resolved
Hide resolved
JoaoBraveCoding
force-pushed
the
2048333
branch
from
9d962c5
to
3e7aecf
Compare
JoaoBraveCoding
force-pushed
the
2048333
branch
from
3e7aecf
to
4a69309
Compare
Problem: Currently the prometheus-adapter pods are restarted at the same time even though the deployment is configured with strategy RollingUpdate. This happens because the kubelet does not know when the prometheus-adapter pods are ready to start receiving requests. Solution: Add both readinessProbe and livenessProbe to the prometheus-adapter, this way the kubelet will know when either the pod stoped working and should be restarted or simply when it ready to start receiving requests. Issue: https://bugzilla.redhat.com/show_bug.cgi?id=2048333
JoaoBraveCoding
force-pushed
the
2048333
branch
from
4a69309
to
652c6d5
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Currently the prometheus-adapter pods are restarted at the same
time even though the deployment is configured with strategy RollingUpdate.
This happens because the kubelet does not know when the prometheus-adapter
pods are ready to start receiving requests.
Solution: Add both readinessProbe and livenessProbe to the
prometheus-adapter, this way the kubelet will know when either the pod
stoped working and should be restarted or simply when it ready to start
receiving requests.
Issue: https://bugzilla.redhat.com/show_bug.cgi?id=2048333
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.