Skip to content

Commit

Permalink
chore: fix filenames to avoid import failures
Browse files Browse the repository at this point in the history
Running `go get github.com/prometheus-operator/prometheus@v0.69.0` fails
with:

```
...
not found: create zip:
pkg/prometheus/testdata/TSDB_config_<_v2.39.0.golden: malformed file
path "pkg/prometheus/testdata/TSDB_config_<_v2.39.0.golden": invalid
char '<'
pkg/prometheus/testdata/TSDB_config_>=_v2.39.0.golden: malformed file
path "pkg/prometheus/testdata/TSDB_config_>=_v2.39.0.golden": invalid
char '>'
```

This commit renames the problematic golden files to avoid characters
which aren't supported by the checksum database.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
  • Loading branch information
simonpasquier committed Nov 8, 2023
1 parent f0b85f3 commit 455f51e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/prometheus/promcfg_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4551,15 +4551,15 @@ func TestTSDBConfig(t *testing.T) {
tsdb: &monitoringv1.TSDBSpec{
OutOfOrderTimeWindow: monitoringv1.Duration("10m"),
},
golden: "TSDB_config_<_v2.39.0.golden",
golden: "TSDB_config_less_than_v2.39.0.golden",
},
{

name: "TSDB config >= v2.39.0",
tsdb: &monitoringv1.TSDBSpec{
OutOfOrderTimeWindow: monitoringv1.Duration("10m"),
},
golden: "TSDB_config_>=_v2.39.0.golden",
golden: "TSDB_config_greater_than_or_equal_to_v2.39.0.golden",
},
} {
t.Run(tc.name, func(t *testing.T) {
Expand Down

0 comments on commit 455f51e

Please sign in to comment.