Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support label_limit, label_name_length_limit and label_value_length_limit configuration fields #4107

Closed
simonpasquier opened this issue Jun 15, 2021 · 1 comment · Fixed by #4195

Comments

@simonpasquier
Copy link
Contributor

What is missing?

Prometheus v2.27.0 introduced 3 new configuration fields to prevent Prometheus from ingesting metrics with "excessive" labels:

  • label_limit
  • label_name_length_limit
  • label_value_length_limit

The Prometheus operator should expose these fields in its CRDs.

See prometheus/prometheus#8291 for details.

Why do we need it?

Feature parity with Prometheus :)

Environment

  • Prometheus Operator version:

N/A

Anything else we need to know?:

Like with enforcedSampleLimit and sampleLimit, we want to enforce minimal values at the Prometheus CRD level as well as support individual limits per ServiceMonitor, PodMonitor and Probe resources.

@slashpai
Copy link
Contributor

If this not urgent I would like to work on it to get better understanding of CRDs :)

slashpai added a commit to slashpai/prometheus-operator that referenced this issue Aug 5, 2021
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Aug 5, 2021
slashpai added a commit to slashpai/prometheus-operator that referenced this issue Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants