thanos: remove deprecated features and support for older versions #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll bump the dependencies and DefaultThanosVersion to v0.5.0 once it's released, which may happen before or after this is merged. cc @brancz |
|
Thank you for the awesome work! Lgtm 👍 |
RiRa12621
pushed a commit
to RiRa12621/prometheus-operator
that referenced
this pull request
Jul 10, 2019
paulfantom
added a commit
to paulfantom/prometheus-operator
that referenced
this pull request
Jul 22, 2019
* upstream/master: pkg/alertmanager: change podManagement policy to parallel to prevent statefulset reconciliation from hanging support KUBECONFIG environment fix namespaceSelector: any Adjust thanos doc accordinly to prometheus-operator#2629 regenerate Add more recent prometheus versions to compatibility matrix make --always-make vendor Adding label selector for AlertManager objects discovery filtering Create docuementation for ingress monitoring pkg/alertmanager: increase terminationGracePeriod to 120 Update Kubernetes client libraries to 1.15.0 alertmanager/statefulset: move gossip port to 9094
yahaa
pushed a commit
to talcoding/prometheus-operator
that referenced
this pull request
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanos support is explicitly flagged as experimental in the documentation which states that it may change significantly without deprecation notice or backward compatibility in any release.
Thanos configuration has changed significantly throughout its early iterations. Most notably, object store configuration was replaced in v0.2.0 and gossip was deprecated in v0.4.0 (removed in v0.5.0). Retaining complete backwards compatibility in prometheus-operator for all version of thanos has unnecessarily complicated its API and implementation.
Per #2623 (comment), this drops support for older versions and simplifies the CRDs.